-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mess with tracing #9281
mess with tracing #9281
Conversation
/werft run 👍 started the job as gitpod-build-at-tracing.1 |
/werft run 👍 started the job as gitpod-build-at-tracing.2 |
}) | ||
: undefined; | ||
let span; | ||
if (!!spanCtx && !!spanCtx.toTraceId()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geropl, I believe that's the root of the issue. traceId
was missing.
} | ||
|
||
if (msg) { | ||
const spanCtx = globalTracer().extract(FORMAT_HTTP_HEADERS, message.properties.headers); | ||
const span = !!spanCtx ? globalTracer().startSpan(`/messagebus/${this.exchangeName}`, { references: [childOf(spanCtx!)] }) : undefined; | ||
let span; | ||
if (!!spanCtx && !!spanCtx.toTraceId()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
traceId
was missing here as well..
@geropl or @mads-hartmann, please help to get this verified. Unfortunately, there are more changes included in this PR just to satisfy the checks, but I left a trace of comments to point to the intended ones. Here is an example: https://ui.honeycomb.io/gitpod/datasets/preview-environments/result/4VSr1r5G3Rh/trace/koZ93EerQPm?span=995d31c40e8dd721 |
@AlexTugarev Thanks a ton for fixing this - the traces indeed look complete! Please have a look at this comment. And then I'm happy to ✔️ 🏁 . |
@geropl, I added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint here obscures the nuance of the change. It'd make it easier for reviewers to first lint the file (can be done with pre-commit run --file <file>
) and then base this on top, to highlight the changes made to tracing.
@easyCZ, you are absolutely right. 😿 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Trying to get rid of the millions of error logged in prod.