Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supervisor: Remove slirp4netns #9213

Merged
merged 1 commit into from
Apr 29, 2022
Merged

supervisor: Remove slirp4netns #9213

merged 1 commit into from
Apr 29, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Apr 11, 2022 •
edited
Loading

Description

This PR is a follow-up PR to #9212
no3 of #8106 (comment)

Related Issue(s)

Relates #8106

How to test

on gitpod
https://to-veths-again3.staging.gitpod-dev.com/workspaces

$ docker run hello-world
$ python -m http.server 5000 # and ensure to be able to access 5000 port from outward

Release Notes

supervisor: Remove slirp4netns

Documentation

@utam0k utam0k mentioned this pull request Apr 11, 2022
Closed
@iQQBot iQQBot changed the base branch from main to to/veths-again April 11, 2022 06:24
@roboquat roboquat added size/L and removed size/XXL labels Apr 11, 2022
@iQQBot
Copy link
Contributor

iQQBot commented Apr 11, 2022

/hold
until #9212 get merged and all workspace clusters deployed

@utam0k utam0k mentioned this pull request Apr 11, 2022
Merged
Base automatically changed from to/veths-again to main April 11, 2022 10:37
@roboquat roboquat added size/XXL and removed size/L labels Apr 11, 2022
@stale
Copy link

stale bot commented Apr 23, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 23, 2022
@iQQBot iQQBot added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Apr 23, 2022
@roboquat roboquat added size/L and removed size/XXL labels Apr 28, 2022
@utam0k utam0k marked this pull request as ready for review April 28, 2022 05:48
@utam0k utam0k requested a review from a team April 28, 2022 05:48
iQQBot
iQQBot approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iQQBot
Copy link
Contributor

iQQBot commented Apr 28, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-vm

👍 started the job as gitpod-build-to-veths-again3.4
(with .werft/ from main)

@iQQBot
Copy link
Contributor

iQQBot commented Apr 29, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-vm

👍 started the job as gitpod-build-to-veths-again3.5
(with .werft/ from main)

@mustard-mh
Copy link
Contributor

/unhold Test good!

@mustard-mh
Copy link
Contributor

/unhold

@roboquat roboquat merged commit 0d57f4a into main Apr 29, 2022
@roboquat roboquat deleted the to/veths-again3 branch April 29, 2022 17:15
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iQQBot iQQBot iQQBot approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production meta: never-stale This issue can never become stale release-note size/L team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@utam0k @iQQBot @mustard-mh @roboquat