Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[registry-facade] Fix IPFS/Redis validation #9200

Merged
merged 3 commits into from
Apr 11, 2022
Merged

[registry-facade] Fix IPFS/Redis validation #9200

merged 3 commits into from
Apr 11, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 8, 2022 •
edited
Loading

Description

Fix Redis validation when IPFS is enabled. Also, update the IPFS and Redis dependencies.

Release Notes

[registry-facade] Fix IPFS/Redis validation

@aledbf
Copy link
Member Author

aledbf commented Apr 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-fixipfs.2

@roboquat roboquat added size/XXL and removed size/S labels Apr 8, 2022
@aledbf aledbf marked this pull request as ready for review April 8, 2022 16:42
@aledbf aledbf requested a review from a team April 8, 2022 16:42
@aledbf aledbf requested a review from a team April 8, 2022 16:42
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team labels Apr 8, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Apr 8, 2022
utam0k
utam0k approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akosyakov
akosyakov approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nandajavarma
nandajavarma approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@nandajavarma nandajavarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

geropl
geropl approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

csweichel
csweichel approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 0d7a2c9 into main Apr 11, 2022
@roboquat roboquat deleted the aledbf/fixipfs branch April 11, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@utam0k utam0k utam0k approved these changes

@csweichel csweichel csweichel approved these changes

@akosyakov akosyakov akosyakov approved these changes

@nandajavarma nandajavarma nandajavarma approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production release-note size/XXL team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aledbf @nandajavarma @akosyakov @csweichel @utam0k @geropl @roboquat