Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-proxy] Deny HTTP ACME challenges #9176

Merged
merged 2 commits into from
Apr 7, 2022
Merged

[ws-proxy] Deny HTTP ACME challenges #9176

merged 2 commits into from
Apr 7, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 7, 2022

Description

Allowing HTTP Acme challenges from workspaces can interfere with the release of new workspace clusters
https://letsencrypt.org/docs/rate-limits/

Release Notes

[ws-proxy] Deny HTTP ACME challenges

@aledbf aledbf requested a review from a team April 7, 2022 12:54
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Apr 7, 2022
csweichel
csweichel reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a ton of sense. Got a minor nit on tests. Would be happy to approve either way.

components/ws-proxy/pkg/proxy/workspacerouter_test.go Outdated Show resolved Hide resolved
@roboquat roboquat merged commit a6fe464 into main Apr 7, 2022
@roboquat roboquat deleted the aledbf/acme branch April 7, 2022 13:10
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @csweichel @roboquat