[gitpod-db] Don't consider garbage-collected prebuilds as potential bases for incremental prebuilds #9121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
jx/lower-cardinality
branch
from
e212bb2 to
87f8858
Compare
geropl
reviewed
Apr 5, 2022
| @@ -754,6 +754,7 @@ export abstract class AbstractTypeORMWorkspaceDBImpl implements WorkspaceDB { | |||
| query = query.orderBy("pws.creationTime", "DESC"); | |||
| query = query.innerJoinAndMapOne("pws.workspace", DBWorkspace, "ws", "pws.buildWorkspaceId = ws.id"); | |||
| query = query.andWhere("ws.deleted = false"); | |||
| query = query.andWhere("ws.contentDeletedTime = ''"); | |||
There was a problem hiding this comment.
Will try this in prod (offline) to get a feeling for cardinality...
There was a problem hiding this comment.
Currently trying this in prod-failover with the official GitLab repo (with and without the fix). Will add findings to the PR description.
EDIT: See examples in PR description
There was a problem hiding this comment.
Reduced cardinality from 16919 to 337. 💪
|
@jankeromnes Thx for tackling this! One small nit: Could you add a comment to this line about the reasoning behind cardinality? That would be golden! |
…ases for incremental prebuilds
jankeromnes
force-pushed
the
jx/lower-cardinality
branch
from
87f8858 to
d7939b2
Compare
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't consider garbage-collected prebuilds as potential bases for incremental prebuilds.
Related Issue(s)
Fixes high cardinality on frequently-run SQL queries.
For example, for the Gitpod repository,
For the official GitLab repository,
How to test
Release Notes
Documentation