Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-manager-bridge] Publish metrics with stale prebuild events #9115

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[ws-manager-bridge] Publish metrics with stale prebuild events #9115

merged 1 commit into from
Apr 5, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 4, 2022 •
edited
Loading

Description

Related Issue(s)

Depends on:

Relates to:

How to test

  1. Start a prebuild
  2. Observe the prebuild has statusVersion set in the DB
  3. Observe statusVersion published to tracing
  4. (when stale events are sent) Metrics are reported with the stale events

Release Notes

Store WorkspaceInstance.status_version in d_b_prebuild_workspace and count prebuild stale events

Documentation

/uncc
/hold

@easyCZ easyCZ force-pushed the mp/prebuild-state-set-version branch from 1800192 to 894c265 Compare April 5, 2022 07:06
Base automatically changed from mp/prebuild-state-version-db to main April 5, 2022 08:22
@roboquat roboquat added size/M and removed size/S labels Apr 5, 2022
@easyCZ easyCZ marked this pull request as ready for review April 5, 2022 08:22
@easyCZ easyCZ requested a review from a team April 5, 2022 08:22
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 5, 2022
@easyCZ easyCZ force-pushed the mp/prebuild-state-set-version branch from 894c265 to 92dbc78 Compare April 5, 2022 08:23
@roboquat roboquat added size/S and removed size/M labels Apr 5, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Apr 5, 2022

/unhold

@roboquat roboquat merged commit 1e9b846 into main Apr 5, 2022
@roboquat roboquat deleted the mp/prebuild-state-set-version branch April 5, 2022 10:57
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @andrew-farries @roboquat