[kots]: change the CPU and memory checks to be min not sum #9071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
reviewed
Apr 4, 2022
mrsimonemms
force-pushed
the
sje/kots-memory
branch
from
31e757b to
c4470c5
Compare
|
@Pothulapati I've also changed the wording on the CPU check as similarly wrong focus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whilst helping someone in the community, noticed that the memory/CPU recommendations and "per node" rather than "per cluster".
This updates the preflight checks to reflect that.
How to test
Install the
preflightplugin and runkubectl preflight kots-preflight.yamlRelease Notes
Documentation