Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Fix Settings menu colors in Dark theme #9052

Merged
merged 1 commit into from
Apr 1, 2022
Merged

[dashboard] Fix Settings menu colors in Dark theme #9052

merged 1 commit into from
Apr 1, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Mar 31, 2022 •
edited
Loading

Description

Follow-up to #9002 to fix Dark theme

BEFORE AFTER
Screenshot 2022-03-31 at 16 32 16 Screenshot 2022-03-31 at 16 34 40

Related Issue(s)

None

How to test

  1. Log in to https://jx-fix-darf62f90ae3c.staging.gitpod-dev.com/preferences
  2. When you switch between Light and Dark themes, the Settings menu on the left should still be readable

Release Notes

[dashboard] Fix Settings menu colors in Dark theme

Documentation

@jankeromnes jankeromnes requested review from gtsiolis and a team March 31, 2022 14:35
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 31, 2022
@jankeromnes jankeromnes mentioned this pull request Mar 31, 2022
Merged
@jankeromnes jankeromnes removed the request for review from gtsiolis March 31, 2022 15:41
AlexTugarev
AlexTugarev approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roboquat roboquat merged commit 9cd8868 into main Apr 1, 2022
@roboquat roboquat deleted the jx/fix-dark-menu-colors branch April 1, 2022 06:34
@mustard-mh mustard-mh mentioned this pull request Apr 1, 2022
Closed
@gtsiolis gtsiolis mentioned this pull request Apr 4, 2022
Closed
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jankeromnes @AlexTugarev @roboquat