[dashboard] Remove prebuild status errors from prebuild logs

[easyCZ]

Description

Removes injection of prebuild/workspace instance status errors into the logs. The error/status is already shown below the logs view.

Doing this addresses the following problems:

• Simplifies state checking logic
• Removes a race-condition where sometimes (fairly frequently) the error is injected at the top of the logs but with enough log output, the error is not in the view.

Related Issue(s)

Fixes #

How to test

1. Clone https://gitlab.com/gitpod-milan/gitpod-large-image
2. Setup the repo in step 1. as a project
3. Trigger pre-builds for the following example branches:
   • main
   • timeout
   • fail
4. Observe the error is not injected into the logs
5. Image build & logs continue to be streamed
6. Once built, logs should continue to be accessible

Release Notes

[dashboard] Remove prebuild error message from prebuild log view

Documentation

/uncc
/hold

[AlexTugarev]

Works as advertised!

[jankeromnes]

Many thanks for this Pull Request! Had a pass through the code changes, and left a few thoughts/questions. Will now try to test this.

[jankeromnes]

Many thanks for responding to my comments/questions! They're now all addressed.

The code changes look good to me now. 👍

I also tried testing this, but for some reason, when I try my go-to image build error repo (https://gitlab.com/jankeromnes/gitpod-build-error), I never get any image build logs.

It always goes straight from "Queued" to "System Error", without showing any image build logs:

BEFORE	AFTER

[jankeromnes]

Approving, because the observed logs problem seems unrelated to this change, and you did get logs for my test repo.

Thanks also for the call! I can't wait for us to have much more robust Prebuild status and logs. 😊

[easyCZ]

It always goes straight from "Queued" to "System Error", without showing any image build logs:

@jankeromnes using your repo, I've managed to get the image build logs.

The case you're observing is a race condition that happens due to the following:

1. We only subscribe for image build logs if the WorksapceInstance is in "preparing" or "stopping" states. Of course, we're running a distributed system so we can easily not receive the update as fast, or skip it entirely. This means that we wouldn't always detect the "preparing" state so we wouldn't start the image build stream :/
2. If you refresh the browser, you may have already moved to the "prebuild failed" status in which case you don't get the image build logs.

I'm looking to tackle both by making the prebuild logs deterministic, but that's outside of the scope of this PR.

[easyCZ]

/unhold

[jankeromnes]

I'm looking to tackle both by making the prebuild logs deterministic

😍