Add script to preload images onto nodes #8898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
reviewed
Mar 21, 2022
dev/preview/distribute-images.sh
Outdated
Comment on lines
15
to
17
|
|
||
| NODES=$(kubectl get nodes -o=jsonpath='{.items[*].metadata.name}') | ||
| NAMESPACE="distribute-${IMAGEID}" |
There was a problem hiding this comment.
Suggested change
| NODES=$(kubectl get nodes -o=jsonpath='{.items[*].metadata.name}') | |
| NAMESPACE="distribute-${IMAGEID}" | |
| // We don't delete the namespace "distribute-${IMAGEID} because we want to avoid | |
| // images from being garbage collected | |
| NODES=$(kubectl get nodes -o=jsonpath='{.items[*].metadata.name}') | |
| NAMESPACE="distribute-${IMAGEID}" |
Suggested change
| NODES=$(kubectl get nodes -o=jsonpath='{.items[*].metadata.name}') | |
| NAMESPACE="distribute-${IMAGEID}" | |
| NODES=$(kubectl get nodes -o=jsonpath='{.items[*].metadata.name}') | |
| NAMESPACE="distribute-${IMAGEID}" |
ArthurSens
reviewed
Mar 21, 2022
ArthurSens
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a script that preloads the VM image onto all harvester nodes by creating a VM on every node.
Related Issue(s)
Fixes # #8634
How to test
Run
./dev/preview/distribute-images.sh -i image-xcx77 -s longhorn-image-xcx77-onereplicaSee VMs getting created.
Release Notes
Documentation