[kots]: remove wait-for-jobs #8871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we're deleting jobs on completion, the Helm command can error wrongly if the job is deleted before Helm detects it's completed.
github-actions
bot
added
the
team: delivery
| @@ -191,7 +191,6 @@ spec: | |||
| --reset-values \ | |||
| --timeout 1h \ | |||
| --wait \ | |||
| --wait-for-jobs \ | |||
There was a problem hiding this comment.
nit: Just wondering if this would falsely give a "Installer job finished" message. Is increasing the ttl of the job a possibility?
There was a problem hiding this comment.
I don't think so. The jobs are decoupled from the install/upgrade process really. Even if it does fail, it doesn't allow us to feedback to the GUI (I don't think KOTS has anything that allows that in fact)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
wait-for-jobsflag in Helm.As we're deleting jobs on completion, the Helm command can error
wrongly if the job is deleted before Helm detects it's completed.
How to test
Deploy via KOTS
Release Notes
Documentation