[server] Fix checkoutLocation for imagebuilds #8854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/8851-imgbuilds
branch
from
d8a2aa4 to
076b573
Compare
|
/werft run |
AlexTugarev
reviewed
Mar 17, 2022
| @@ -726,13 +726,13 @@ export class WorkspaceStarter { | |||
| ) { | |||
| // TODO(se): we cannot change this initializer structure now because it is part of how baserefs are computed in image-builder. | |||
| // Image builds should however just use the initialization if the workspace they are running for (i.e. the one from above). | |||
|
|
|||
| checkoutLocation = "."; | |||
There was a problem hiding this comment.
that makes sense, as it does also have effect on contextPath and dockerFilePath.
just, I don't the comments from prev lines.
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This attemps to fix the problem by replicating the original mechanism as close as possible.
The general problem here is obviously that we're lagging tests for
workspace-starter.ts. 🙄Thx @iQQBot for identifying the problem with #8833 🙏
Related Issue(s)
Fixes #8851
How to test
Release Notes
Documentation