[dashboard]: Use prebuild record when determining prebuild actions #8841
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
easyCZ
force-pushed
the
mp/prebuild-logs
branch
from
5573078 to
dcdd384
Compare
easyCZ
force-pushed
the
mp/prebuild-logs
branch
2 times, most recently
from
85a3f2f to
ae559bf
Compare
easyCZ
changed the title
|
/werft run |
| @@ -19,7 +19,6 @@ const WorkspaceLogs = React.lazy(() => import("./WorkspaceLogs")); | |||
|
|
|||
| export interface PrebuildLogsProps { | |||
| workspaceId?: string; | |||
| onInstanceUpdate?: (instance: WorkspaceInstance) => void; | |||
There was a problem hiding this comment.
Removed as the change to Prebuild.tsx was the only remaining usage.
|
/werft run |
easyCZ
force-pushed
the
mp/prebuild-logs
branch
3 times, most recently
from
80967a0 to
f444087
Compare
| @@ -56,6 +55,16 @@ export default function () { | |||
| }); | |||
| setPrebuild(prebuilds[0]); | |||
| })(); | |||
|
|
|||
| return getGitpodService().registerClient({ | |||
There was a problem hiding this comment.
Instead of previously receiving updates through the onInstanceUpdate (which came from a child component), we now receive the prebuild updates directly here.
There was a problem hiding this comment.
Note that we have a gap here on reconnects: To make this bullet-proof we'd need to detect reconnects, and actively fetch the current state afterwards to ensure we stay up-to-date (there is a utility that does so for instance-updates built into the TS client, but I don't think there is one for the prebuild).
However let's not block here, but maybe take a note/create a follow-up issues - this is already much better than the status quo.
easyCZ
force-pushed
the
mp/prebuild-logs
branch
2 times, most recently
from
9ffa7ac to
59244a0
Compare
|
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-prebuild-logs.24 |
|
/werft run with-clean-slate-deployment=true |
|
@easyCZ converted to draft bc I saw a recent push, and am trying to follow my own "PR reviews" script 🙄 👍 ... feedback welcome! 💯 |
|
@geropl The push is a rebase to try and get image builds working on the preview environment as suggested in internal slack. |
roboquat
added
deployed: webapp
Description
Actions shown on Prebuild Detail view are now based on the
prebuildrecord, rather than a Workspace Instance.Visual remain unchanged, only logic for showing various buttons is updated.
Related Issue(s)
Relates to #8197
How to test
Release Notes
/hold