[server] Improve GitHub Enterprise avatars handling #8825
Conversation
|
Hmm, of course, neither our GHE user nor its org have Gravatars, so that doesn't help 😅
But I guess this is the best we can do. I'll also fix the avatar width in the workspaces list and call it done. 😕 |
…xt when avatar can't be loaded
jankeromnes
force-pushed
the
jx/fix-ghe-org-avatars
branch
from
4b353d7 to
aea5dbb
Compare
jankeromnes
changed the title
There was a problem hiding this comment.
I was in the neighborhood and left one comment below.
Thanks for tackling this, @jankeromnes!
| accountAvatarUrl: r.owner?.avatar_url, | ||
| account: r.owner.login, | ||
| accountAvatarUrl: r.owner.gravatar_id | ||
| ? `https://www.gravatar.com/avatar/${r.owner.gravatar_id}?size=128` |
There was a problem hiding this comment.
issue: This is still failing to load the avatar when there's no gravatar set, right?
| New project | Project branches |
|---|---|
 |
 |
There was a problem hiding this comment.
Yes. I really tried to find a way to get the avatar from GitHub Enterprise, but it absolutely refuses to serve the avatar unless you're logged in as a user to GHE with a browser cookie (i.e., no API call can actually serve the image, it only gives you its URL, and the avatar URL refuses any sort of token you throw at it and always redirects to interactive login).
There was a problem hiding this comment.
Ah, I see. Still, grabbing the gravatar is a small improvement step.
| account: r.owner.login, | ||
| accountAvatarUrl: r.owner.gravatar_id | ||
| ? `https://www.gravatar.com/avatar/${r.owner.gravatar_id}?size=128` | ||
| : r.owner.avatar_url, |
There was a problem hiding this comment.
thought: Posting this here in case it helps. GitHub, incl. GHE, allows you to fetch the user avatar by appending the username with .png suffix, like /username.png. But you have to be logged in for GHE to work. 😞
roboquat
added
deployed: webapp
Description
GitHub Enterprise doesn't seem to allow cross-origin requests for user avatars, leading to a broken Gitpod UI.
Also, I initially wanted to fetch the avatars, and encode them as data URIs, however GitHub Enterprise also doesn't seem to have an API to download avatars (only browser authentication via cookies seems to work).
Thankfully, GitHub Enterprise does provide a Gravatar ID that we can use. This Pull Request does just that whenever possible, and also improves the display of avatars that cannot be found or loaded.
Related Issue(s)
Fixes #8755
Partially improves #8815
How to test
/newRelease Notes
Documentation