Use new cron plugin for Werft cron jobs #8744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job was never succesfully triggered and we can now have a cron job that we can execute instead. Fixes gitpod-io/ops#981
Also moves delete-preview-environments-cron to .werft as we now have to rely on Werft detecting the job specification. Previously we had it in the Werft config with a specific path, so that wasn't important before, but as the cron expression is now part of the job spec we are depending on Werft finding the job (and it only looks directly in the .werft folder) Fixes gitpod-io/ops#1255
Werft currently only detects jobs in the .werft folder (not subfolders) so for it to pick up the job with the cron expression it has to be in the .werft folder.
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Codecov Report
@@ Coverage Diff @@
## main #8744 +/- ##
=======================================
Coverage 11.17% 11.17%
=======================================
Files 18 18
Lines 993 993
=======================================
Hits 111 111
Misses 880 880
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ArthurSens
previously approved these changes
Mar 11, 2022
felladrin
reviewed
Mar 11, 2022
|
@ArthurSens No additional things to prepare, so just have to get it merged so I can see if Werft does indeed respect these new cron expressions |
One of them were wrong :D
ArthurSens
approved these changes
Mar 11, 2022
felladrin
approved these changes
Mar 11, 2022
mads-hartmann
added a commit
that referenced
this pull request
Mar 14, 2022
In #8744 I moved files around but had forgotten to update references to the files. Fixes gitpod-io/ops#1255
roboquat
pushed a commit
that referenced
this pull request
Mar 14, 2022
In #8744 I moved files around but had forgotten to update references to the files. Fixes gitpod-io/ops#1255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves our existing Werft cron jobs to use the cron plugin which was released in Werft 0.2.0. This greatly simplifies the process for adding and updating Werft cron jobs as you no longer have to modify the Werft config and restart the service when adding or modifying the cron expressions for a cron job.
As Werft only detects jobs in
.werftI had to move the existing cron jobs to.werft- previously this wasn't an issue as the cron definitions for each job in the Werft config pointed to a specific file. But now we're relying on Werft detecting the jobs in order to see the cron expression, so the job specifications need to live directly in.werft.I introduced the same naming convention as we have in gitpod-io/ops, which is
<team name>-<job-name>and updated CODEOWNERS.I deleted the
delete-preview-environmentsjob and instead changed thedelete-preview-environments-cronjob to run every hour. Werft never triggereddelete-preview-environmentswhen branches were deleted so we have never seen the job work. Cleaning preview environments every hour is good enough for now.Related Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/1255
How to test
Once merged we have to verify that Werft does indeed schedule the cron jobs. As the delete preview environments cron job now runs every hour I will use that one to verify that it gets triggered.
Release Notes
Documentation
I have to updated our How-to guides on how to add cron jobs.