Werft tracing improvements #8743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8743 +/- ##
=======================================
Coverage 11.17% 11.17%
=======================================
Files 18 18
Lines 993 993
=======================================
Hits 111 111
Misses 880 880
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
mads-hartmann
force-pushed
the
mads/werft-tracing
branch
from
10b776e to
8b9123e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the graceful shutdown logic to a "finally" block and introduces separate phases for the shutdown logic. Previously the shutdown logs would just to to the last open phase which was a bit confusing.
With this change I haven't been able to reproduce #8727 but I don't see how this change should fix it. However, as this is an improvement I'd like to get it into main and then see if I can reproduce #8727 off a new branch.
Related Issue(s)
Part of #8727 but suspect not the solution.
How to test
I was able to reproduce the #8727 error here (job 3, trace) but never again after introducing the change (job 4, trace). And that's even when I tried clean-slate-deployment (job 6, trace). Even so, I don't this change is the fix and suspect there's some other race condition or similar that I just didn't hit.
Release Notes
Documentation
N/A