Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-manager-bridge] Document ClusterService rpcs and messages #8721

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[ws-manager-bridge] Document ClusterService rpcs and messages #8721

merged 1 commit into from
Mar 10, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Mar 10, 2022 •
edited
Loading

Description

Because I had to reverse-engineer these from the code, and the design doc, and I feel like I shouldn't have to.

Release Notes

Document ClusterService rpcs and messages

Documentation

@easyCZ easyCZ changed the title Document ClusterService rpcs and messages [ws-manager-bridge] Document ClusterService rpcs and messages Mar 10, 2022
@roboquat roboquat added size/M and removed size/S labels Mar 10, 2022
@easyCZ easyCZ requested a review from a team March 10, 2022 15:27
@easyCZ easyCZ marked this pull request as ready for review March 10, 2022 15:27
@easyCZ easyCZ requested review from csweichel and geropl as code owners March 10, 2022 15:28
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 10, 2022
geropl
geropl approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #8721 (291908e) into main (bc1e9fa) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8721      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1e9fa...291908e. Read the comment docs.

@roboquat roboquat merged commit d43b464 into main Mar 10, 2022
@roboquat roboquat deleted the mp/cs-comments branch March 10, 2022 15:59
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@csweichel csweichel Awaiting requested review from csweichel

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @geropl @roboquat