Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots]: add standard labels to KOTS manifests #8708

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Mar 10, 2022

Description

Add labels to the gitpod- KOTS resources. Notice these were missing during this morning's demo. This will allow for KOTS support bundles to pick these resources up.

How to test

Deploy to KOTS

Release Notes

[kots]: add standard labels to KOTS manifests

Documentation

@mrsimonemms mrsimonemms marked this pull request as ready for review March 10, 2022 11:39
@mrsimonemms mrsimonemms requested a review from a team March 10, 2022 11:39
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Mar 10, 2022
@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Mar 10, 2022

/werft run no-preview

👍 started the job as gitpod-build-sje-kots-labels.3

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #8708 (e0ed3cc) into main (0f44fe9) will decrease coverage by 1.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8708      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to these labels for gitpod-clusterrolebinding.yaml , gitpod-serviceaccount.yaml. Any specific reason for leaving RBAC resources? 🤔

@mrsimonemms
Copy link
Contributor Author

We seem to these labels for gitpod-clusterrolebinding.yaml , gitpod-serviceaccount.yaml. Any specific reason for leaving RBAC resources? thinking

Can you explain please @Pothulapati? These labels are already present in these two files. The labels are added to allow for the support bundle to pick up these additional files that have been added by KOTS

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, My bad on both the comments. :p

Yep, The Labels are in those files too! LGTM 💯

@roboquat roboquat merged commit bcf72bc into main Mar 11, 2022
@roboquat roboquat deleted the sje/kots-labels branch March 11, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants