-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kots]: add standard labels to KOTS manifests #8708
Conversation
2055320
to
e0d5b1a
Compare
e0d5b1a
to
e0ed3cc
Compare
/werft run no-preview 👍 started the job as gitpod-build-sje-kots-labels.3 |
Codecov Report
@@ Coverage Diff @@
## main #8708 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to these labels for gitpod-clusterrolebinding.yaml
, gitpod-serviceaccount.yaml
. Any specific reason for leaving RBAC resources? 🤔
Can you explain please @Pothulapati? These labels are already present in these two files. The labels are added to allow for the support bundle to pick up these additional files that have been added by KOTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, My bad on both the comments. :p
Yep, The Labels are in those files too! LGTM 💯
Description
Add labels to the
gitpod-
KOTS resources. Notice these were missing during this morning's demo. This will allow for KOTS support bundles to pick these resources up.How to test
Deploy to KOTS
Release Notes
Documentation