Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align dashboard plans page wording on website #8699

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Conversation

lucasvaltl
Copy link
Contributor

Description

After watching a YouTube review of gitpod, I noticed the wording around Timeouts on the dashboard/settings/plans page is inconsistent with the wording on our website/pricing page. It can lead to the reader assuming that on the free plan you workspace automatically times out after 30 mins, not that it times out after 30 mins of inactivity. This was also assumed by the reviewer. Hence I added "inactivity" as a qualifier before "timeout" to clarify this. This is also the wording used on the pricing page.

How to test

Run gitpod, look at the dashboards/settings/plans page to see that the changes came through

Release Notes

Clarified wording of "timeout" feature on the settings/plans page

@lucasvaltl lucasvaltl requested a review from a team March 9, 2022 17:50
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 9, 2022
@lucasvaltl
Copy link
Contributor Author

Note that I did not test this within the workspace at all. Just made the changes to the files.

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 9, 2022

Running build again in case it helps with the build failure[1].

/werft run

👍 started the job as gitpod-build-lucas-dashb-wrd-fix.2

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, @lucasvaltl! 🔮

UX changes look good. ✔️

Not sure why the build is failing here. I've noticed others are also running into this error, see relevant discussion (internal). Let's see what others think.

@lucasvaltl
Copy link
Contributor Author

lucasvaltl commented Mar 10, 2022

Seems like there was a quota issue (see discussion (internal) - let's try this again:

/werft run

👍 started the job as gitpod-build-lucas-dashb-wrd-fix.3

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #8699 (e659939) into main (754114d) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8699      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754114d...e659939. Read the comment docs.

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Many thanks 🙏

Approving because George already approved and this looks safe ✅

@roboquat roboquat merged commit 9b8031e into main Mar 11, 2022
@roboquat roboquat deleted the lucas-dashb-wrd-fix branch March 11, 2022 10:24
@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 11, 2022

Thanks, @jankeromnes @lucasvaltl! 🏀

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants