-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align dashboard plans page wording on website #8699
Conversation
Note that I did not test this within the workspace at all. Just made the changes to the files. |
Running build again in case it helps with the build failure[1]. /werft run 👍 started the job as gitpod-build-lucas-dashb-wrd-fix.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change, @lucasvaltl! 🔮
UX changes look good. ✔️
Not sure why the build is failing here. I've noticed others are also running into this error, see relevant discussion (internal). Let's see what others think.
Seems like there was a quota issue (see discussion (internal) - let's try this again: /werft run 👍 started the job as gitpod-build-lucas-dashb-wrd-fix.3 |
Codecov Report
@@ Coverage Diff @@
## main #8699 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Many thanks 🙏
Approving because George already approved and this looks safe ✅
Thanks, @jankeromnes @lucasvaltl! 🏀 |
Description
After watching a YouTube review of gitpod, I noticed the wording around Timeouts on the dashboard/settings/plans page is inconsistent with the wording on our website/pricing page. It can lead to the reader assuming that on the free plan you workspace automatically times out after 30 mins, not that it times out after 30 mins of inactivity. This was also assumed by the reviewer. Hence I added "inactivity" as a qualifier before "timeout" to clarify this. This is also the wording used on the pricing page.
How to test
Run gitpod, look at the dashboards/settings/plans page to see that the changes came through
Release Notes