Add some tests for cgroup v2 #8658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8658 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
utam0k
commented
Mar 8, 2022
test/tests/workspace/k3s_test.go
Outdated
| Command: "bash", | ||
| Args: []string{ | ||
| "-c", | ||
| "while [ ! -e /workspace/k3s ]; do sleep 1; done && sudo chmod +x /workspace/k3s && sleep 20 && sudo /workspace/k3s kubectl wait --for=condition=Ready nodes -l node-role.kubernetes.io/master=true --timeout 30s && sudo /workspace/k3s kubectl get nodes", |
There was a problem hiding this comment.
This is a draft now because we need sleep 20. Without it, the Text file will be busy. I plan to fix this.
utam0k
force-pushed
the
to/cgv2-itest
branch
6 times, most recently
from
93d4db5 to
91b36bb
Compare
roboquat
added
release-note-none
and removed
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
labels
Furisto
reviewed
Mar 9, 2022
utam0k
force-pushed
the
to/cgv2-itest
branch
3 times, most recently
from
b170bac to
63741ad
Compare
|
@Furisto PTAL |
|
@utam0k Can you squash your commits? Chris has reminded me that we should not have too many commits. |
Furisto
approved these changes
Mar 11, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #8627
How to test
Run the integration test following README of tests.
(e.g. https://werft.gitpod-dev.com/job/gitpod-custom-to-cgv2-itest.2/logs)
For cgroup v2, you need to prepare a dedicated image to build the environment. core-dev is cgoup v1, so the test for cgroup v2 is skipped.
gitpod-k3s-202203090157-cgv2is the image that set the cgroup v2 setting.Release Notes
Documentation