werft/build/prepare: Cleanup code #8643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArthurSens <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #8643 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
meysholdt
reviewed
Mar 8, 2022
|
|
||
| const werftImg = shell.exec("cat .werft/build.yaml | grep dev-environment").trim().split(": ")[1]; | ||
| const devImg = shell.exec("yq r .gitpod.yml image").trim(); | ||
| // TODO: The reasoning behind this step should be clarified |
There was a problem hiding this comment.
it's because both images need to be updated separately and letting them go out of sync may cause weird follow-up errors.
meysholdt
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of changes to make code cleaner:
execfromutil/shellinstead of using it fromshelljsat some places.preparefunction to no longer hold any logic, only calling several smaller private functions.preparefunctionRelated Issue(s)
Fixes #
How to test
Start a new job, you shouldn't notice any difference
Release Notes