-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce TeamSubscription.noMoreResources to be able to exclude TeamSubscriptions from bigger clusters #8608
Conversation
/werft run 👍 started the job as gitpod-build-gpl-8472-limit-res.2 Re-try certificate |
Codecov Report
@@ Coverage Diff @@
## main #8608 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
components/gitpod-db/src/typeorm/entity/db-team-subscription.ts
Outdated
Show resolved
Hide resolved
d390015
to
49e29ab
Compare
components/gitpod-db/src/typeorm/entity/db-team-subscription.ts
Outdated
Show resolved
Hide resolved
49e29ab
to
1c3dd1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the quick fix @geropl! 🚀
Code looks good to me, and the unit test adds a lot of confidence. Also, the migrated (empty) DB looks good. 👍
Still, I'd feel a bit safer testing this with an actual chargebee integration. Adding a hold in case you want to add an integration in this PR, but I'm also happy to fully test this on staging (i.e. please feel free to unhold 🚢).
/hold
1c3dd1a
to
fbadc09
Compare
/unhold
As this is only about how we interpret our own model I think it's fine, especially with the test. @jankeromnes Need re-approval for the removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, re-approved! 🚀
Oh, oops -- Werft failed with:
|
fbadc09
to
1f5faf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still good to go! 🚀
Description
This introduces a
noMoreResources
column onTeamSubscription
that can be used to exclude it's members from receivingmore-resources
.Related Issue(s)
Fixes #8472
How to test
Release Notes
Documentation