Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve werft job build speed and make honeycomb more accurate #8577

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Mar 3, 2022

Description

Current werft job honeycomb shows that pull image secret take a long time, which is not accurate, because we don't DONE pull image secret slice for some conditions

And reuse last port almost not work, this takes really long time to get used port, because we always want to get node-exporter port, which is only enable by withObservability flag.

Before After
image image

This PR fixes these

Related Issue(s)

Fixes #

How to test

Comment /werft run in this PR to see werft job log and honeycomb

Release Notes

NONE

Documentation

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #8577 (586c788) into main (e931577) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8577      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e931577...586c788. Read the comment docs.

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Mar 3, 2022

/werft run

👍 started the job as gitpod-build-hw-werft-improve.1

@mustard-mh mustard-mh marked this pull request as ready for review March 3, 2022 17:20
@mustard-mh mustard-mh requested review from ArthurSens and iQQBot March 3, 2022 17:20
@roboquat roboquat merged commit 010e7f6 into main Mar 4, 2022
@roboquat roboquat deleted the hw/werft-improve branch March 4, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants