Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workspace search under user detail #8562

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Fix workspace search under user detail #8562

merged 1 commit into from
Mar 3, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Mar 3, 2022 •
edited
Loading

Description

Fixes the bug where a user detail fetches all workspaces instead of only their own.

Related Issue(s)

Fixes #8561

How to test

  1. Have more than one user in the preview env[1]
  2. Go to user detail - the workspaces list should only show the user's workspaces.

Release Notes

Fix user detail bug that fetches all workspaces.

Documentation

@laushinka laushinka requested a review from a team March 3, 2022 11:05
@laushinka laushinka requested a review from geropl March 3, 2022 11:05
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 3, 2022
@laushinka
Copy link
Contributor Author

@geropl I wasn't aware that ownerId was used for workspace searches under user detail, so I have put it back.

@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited
Loading

Codecov Report

Merging #8562 (13daf2a) into main (4b67f8e) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8562      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b67f8e...13daf2a. Read the comment docs.

@laushinka laushinka requested review from jldec and gtsiolis March 3, 2022 11:18
@laushinka laushinka mentioned this pull request Mar 3, 2022
Closed
@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 3, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

gtsiolis
gtsiolis approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX LGTM. ✔️

Thanks for fixing this, @laushinka! ✨

JanKoehnlein
JanKoehnlein approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geropl
geropl approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works ✔️

@roboquat roboquat merged commit 29df192 into main Mar 3, 2022
@roboquat roboquat deleted the lm/ws-user-list-8651 branch March 3, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

@gtsiolis gtsiolis gtsiolis approved these changes

@jldec jldec Awaiting requested review from jldec

Assignees
No one assigned
Labels
release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspaces list under user fetches all workspaces
5 participants
@laushinka @gtsiolis @JanKoehnlein @geropl @roboquat