Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable GatewayBranding customization to fix workspace not connecting through JetBrains IDEs #8542

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Mar 2, 2022

Description

Temporarily disable GatewayBranding customization to fix workspace not connecting through JetBrains IDEs.

Related Issue(s)

Fixes #8437

How to test

Open a new workspace with any JetBrains IDE and check if it connects successfully.

Release Notes

NONE

Documentation

@iQQBot
Copy link
Contributor

iQQBot commented Mar 2, 2022

Just curious, why does this affect?

@iQQBot
Copy link
Contributor

iQQBot commented Mar 2, 2022

In the preview environment, only the main is affected, but even if I create another branch that is exactly the same as the main, it is not affected

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akosyakov
Copy link
Member

@iQQBot we don't know, but JB folks confirmed that it is a root cause. We don't know more.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8542 (2487cf7) into main (863bb02) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8542      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863bb02...2487cf7. Read the comment docs.

@roboquat roboquat merged commit 4e7709a into main Mar 2, 2022
@roboquat roboquat deleted the vn/hotfix-jb branch March 2, 2022 15:29
@felladrin felladrin changed the title Temporarily comment out GitpodBranding to fix workspace not connecting through JetBrains IDEs Temporarily disable GatewayBranding customization to fix workspace not connecting through JetBrains IDEs Mar 2, 2022
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not connect to workspace when opening using a JetBrains IDE from the workspace start page
4 participants