-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Replicated/KOTS dependencies to image #8538
Conversation
/hold |
5b28ac4
to
f432394
Compare
f432394
to
bc5088f
Compare
Codecov Report
@@ Coverage Diff @@
## main #8538 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bc5088f
to
4cdb0ab
Compare
dev/image/Dockerfile
Outdated
RUN brew install replicatedhq/replicated/cli kubectl helm && \ | ||
curl https://kots.io/install | bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2 cents on this:
kubectl
is already part of the image, we don't need to install it here again.- I would prefer to avoid using
brew
and use the Linux install step instead:$ curl https://raw.githubusercontent.com/replicatedhq/replicated/master/install.sh | bash
- Both, the Replicated CLI install bash script and the KOTS install bash script simply download the latest release from the GitHub release page. We could also download the binaries directly (and check the sha hash etc.). However, then we need to take care that we update the version regularly.
- We used to have
helm
in the image. You could use the commit 88ff2c2 as a reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry my bad. I copy/pasta from the old PR and forgot to remove the relevant stuff. Will update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support your points, Cornelius.
then we need to take care that we update the version regularly.
+1 for version locking. Upgrading the versions from time to time manually is usually less painful than stuff breaking when you have the least time for and waste hours until you realize that an automated version update happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the fixes and added version locks.
7d24663
to
f4d55df
Compare
f4d55df
to
1ce88bd
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@mrsimonemms can the hold
label be removed?
/unhold |
Description
Add Replicated and KOTS dependencies to the main image. This allows us to do the development required in
/install/kots
How to test
Release Notes
Documentation