-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go dependencies #8533
Update go dependencies #8533
Conversation
cceb7ac
to
3d5ea20
Compare
Codecov Report
@@ Coverage Diff @@
## main #8533 +/- ##
=========================================
- Coverage 12.31% 7.55% -4.77%
=========================================
Files 20 31 +11
Lines 1161 2171 +1010
=========================================
+ Hits 143 164 +21
- Misses 1014 2004 +990
+ Partials 4 3 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cffe269
to
c49ca04
Compare
LGTM I would like to get @ArthurSens's approval on this as well as the new module adds both See #8532 for details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM /hold
I would like to get @ArthurSens's approval on this as well as the new module adds both
availableReplicas: 0
andreplicas: 0
to thestate
in the OpenVSX Proxy stateful set. I believe that the post-processing we did yesterday will handle this, but worth checkingSee #8532 for details
I've just tested this PR with and without that post-processing workaround, and the job fails without it. I believe this is safe to merge since we got this workaround in place, but looking forward to finding a solution where we don't need it 😅
/unhold |
@csweichel pinging to avoid staleness |
Description
Related Issue(s)
Fixes #
How to test
Release Notes