Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go dependencies #8533

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Update go dependencies #8533

merged 2 commits into from
Mar 3, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 2, 2022

Description

  • Update k8s go dependencies to v1.23.4
  • Update prometheus to v1.12.1 CVE-2022-21698
  • Update containerd to v1.6.0

Related Issue(s)

Fixes #

How to test

Release Notes

Update k8s go dependencies to v1.23.4
Update prometheus to v1.12.1 [CVE-2022-21698](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-21698)
Update containerd to v1.6.0

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8533 (f8ed8da) into main (7ac5d9d) will decrease coverage by 4.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #8533      +/-   ##
=========================================
- Coverage   12.31%   7.55%   -4.77%     
=========================================
  Files          20      31      +11     
  Lines        1161    2171    +1010     
=========================================
+ Hits          143     164      +21     
- Misses       1014    2004     +990     
+ Partials        4       3       -1     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app 4.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
install/installer/pkg/common/render.go 0.00% <0.00%> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go 0.00% <0.00%> (ø)
install/installer/pkg/common/ca.go 0.00% <0.00%> (ø)
install/installer/pkg/common/common.go 4.43% <0.00%> (ø)
...nstall/installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
...l/installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
...installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
...l/installer/pkg/components/ws-manager/configmap.go 23.75% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac5d9d...f8ed8da. Read the comment docs.

@aledbf aledbf force-pushed the aledbf/update branch 3 times, most recently from cffe269 to c49ca04 Compare March 2, 2022 21:02
@aledbf aledbf marked this pull request as ready for review March 2, 2022 21:16
@aledbf aledbf requested a review from a team March 2, 2022 21:16
@aledbf aledbf requested review from csweichel and geropl as code owners March 2, 2022 21:16
@aledbf aledbf requested review from a team March 2, 2022 21:16
@github-actions github-actions bot added team: IDE team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Mar 2, 2022
@mrsimonemms
Copy link
Contributor

LGTM
/hold

I would like to get @ArthurSens's approval on this as well as the new module adds both availableReplicas: 0 and replicas: 0 to the state in the OpenVSX Proxy stateful set. I believe that the post-processing we did yesterday will handle this, but worth checking

See #8532 for details

Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM /hold

I would like to get @ArthurSens's approval on this as well as the new module adds both availableReplicas: 0 and replicas: 0 to the state in the OpenVSX Proxy stateful set. I believe that the post-processing we did yesterday will handle this, but worth checking

See #8532 for details

I've just tested this PR with and without that post-processing workaround, and the job fails without it. I believe this is safe to merge since we got this workaround in place, but looking forward to finding a solution where we don't need it 😅

@mrsimonemms
Copy link
Contributor

/unhold

@geropl
Copy link
Member

geropl commented Mar 3, 2022

@csweichel pinging to avoid staleness

@roboquat roboquat merged commit 89105f8 into main Mar 3, 2022
@roboquat roboquat deleted the aledbf/update branch March 3, 2022 13:16
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production labels Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note size/XXL team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants