Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codehelper nil point #8526

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix codehelper nil point #8526

merged 1 commit into from
Mar 2, 2022

Conversation

mustard-mh
Copy link
Contributor

Description

Fix codehelper nil point

Related Issue(s)

Fixes #

How to test

open preview environment and start with context https://github.com/open-vsx/publish-extensions

Release Notes

NONE

Documentation

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8526 (c555844) into main (05217c7) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8526      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-ide-code-codehelper-app ∅ <ø> (?)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05217c7...c555844. Read the comment docs.

@roboquat roboquat merged commit dfcc39c into main Mar 2, 2022
@roboquat roboquat deleted the hw/code-helper-nil branch March 2, 2022 10:00
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants