Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UA logo #8478

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Add UA logo #8478

merged 1 commit into from
Feb 28, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Feb 28, 2022

Description

This will temporoarily add the logo version with UA colors for the workspace start page. 🇺🇦

Thanks @JohannesLandgraf for the idea. 💡

Release Notes

NONE

@gtsiolis gtsiolis requested a review from a team February 28, 2022 07:33
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #8478 (0a13de2) into main (1f63f30) will decrease coverage by 16.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8478       +/-   ##
===========================================
- Coverage   27.19%   11.17%   -16.02%     
===========================================
  Files          46       18       -28     
  Lines        5931      993     -4938     
===========================================
- Hits         1613      111     -1502     
+ Misses       4199      880     -3319     
+ Partials      119        2      -117     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-ws-manager-app ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/create.go
components/ws-manager/pkg/manager/imagespec.go
components/ws-manager/pkg/manager/metrics.go
...components/ws-manager/unpriviledged-rolebinding.go
components/ws-manager/pkg/clock/clock.go
.../installer/pkg/components/ws-manager/deployment.go
install/installer/pkg/common/objects.go
components/local-app/pkg/auth/pkce.go
install/installer/pkg/common/common.go
...l/installer/pkg/components/ws-manager/tlssecret.go
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f63f30...0a13de2. Read the comment docs.

Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇺🇦

@roboquat roboquat merged commit fde93a4 into main Feb 28, 2022
@roboquat roboquat deleted the gt/add-ua-logo branch February 28, 2022 08:07
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 28, 2022

Thanks for taking a look, @JanKoehnlein! ✊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants