Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change alert period for ws stuck on starting or stopping to 20m #8469

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

sagor999
Copy link
Contributor

Description

Reduce alert period from 1h to 20m for GitpodWorkspaceStuckOnStarting and GitpodWorkspaceStuckOnStopping.
Reasoning:
Currently it takes one hour of that alert firing before pager duty gets issued. This is not great customer experience.
I checked in grafana for the last 7 days and that change should not produce any false positives.

Related Issue(s)

Fixes #

How to test

Release Notes

none

Documentation

@sagor999 sagor999 requested a review from a team February 26, 2022 18:06
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 26, 2022
@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #8469 (bf39aa0) into main (f36d44f) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8469      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f36d44f...bf39aa0. Read the comment docs.

@roboquat roboquat merged commit ebb2a33 into main Mar 1, 2022
@roboquat roboquat deleted the pavel/alert-fix branch March 1, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants