Laushinka/team admin 8060 #8402

laushinka · 2022-02-23T10:07:09Z

Description

Allows managing teams as admin.

SEARCH RESULT	TEAM DETAIL	DELETED TEAM

Related Issue(s)

Fixes #8060

How to test

https://laushinka-team-admin-8060.staging.gitpod-dev.com/

Create a team with member(s)
Visit /admin/teams and search for teams

Release Notes

Admins can find teams, see team details, and change a team member's role.

Documentation

laushinka · 2022-02-23T10:09:50Z

@jldec @gtsiolis This is still a draft, but feel free to play around so we can detect issues.

codecov · 2022-02-23T10:20:54Z

Codecov Report

Merging #8402 (42946c5) into main (6afc7f2) will increase coverage by 2.75%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            main    #8402      +/-   ##
=========================================
+ Coverage   8.41%   11.17%   +2.75%     
=========================================
  Files         33       18      -15     
  Lines       2340      993    -1347     
=========================================
- Hits         197      111      -86     
+ Misses      2138      880    -1258     
+ Partials       5        2       -3

Flag	Coverage Δ
components-gitpod-cli-app	`11.17% <ø> (ø)`
components-local-app-app-darwin-amd64	`?`
components-local-app-app-darwin-arm64	`?`
components-local-app-app-linux-amd64	`?`
components-local-app-app-linux-arm64	`?`
components-local-app-app-windows-386	`?`
install-installer-raw-app	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../installer/pkg/components/ws-manager/deployment.go
...l/installer/pkg/components/ws-manager/configmap.go
components/local-app/pkg/auth/pkce.go
install/installer/pkg/common/display.go
...installer/pkg/components/ws-manager/rolebinding.go
...components/ws-manager/unpriviledged-rolebinding.go
components/local-app/pkg/auth/auth.go
...nstall/installer/pkg/components/ws-manager/role.go
...l/installer/pkg/components/ws-manager/tlssecret.go
install/installer/pkg/common/storage.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afc7f2...42946c5. Read the comment docs.

laushinka · 2022-02-23T11:55:46Z

@jldec @gtsiolis

I will be removing the Owner/Member dropdown, since we won't be allowing role changes right now.
I see there is a design view for the deleted team detail[1]. However when a team is deleted, we also don't see any members because they will have been deleted as well.

gtsiolis · 2022-02-23T14:47:41Z

Looking at this now, round two! 🥊

gtsiolis

Thanks for opening this PR, @laushinka! 🌟

UX looks good. Left some comments below that are complementary to what @jldec added in #8060 (comment).

components/dashboard/src/App.tsx

components/dashboard/src/admin/TeamDetail.tsx

laushinka · 2022-02-23T15:06:51Z

Looking at this now! 👀

@gtsiolis Jürgen updated the tasks list[1] based on the WIP and your suggestions 🙏🏽

laushinka · 2022-02-23T21:21:27Z

@jldec @gtsiolis Ready for review (not a draft anymore).
Also now that we have a slug under the team name in the team detail, would be nice to get input about the layout 🙏🏽

gtsiolis · 2022-02-24T10:02:37Z

Looking at this now! 👀

gtsiolis

Thanks for updating this and addressing all comments, @laushinka!

Left some second review round comments below. 🥊

components/dashboard/src/admin/TeamsSearch.tsx

components/dashboard/src/admin/TeamDetail.tsx

laushinka · 2022-02-24T15:21:42Z

Love this 🤣

gtsiolis

Thanks, @laushinka! Round three! 🥊

components/dashboard/src/admin/TeamsSearch.tsx

components/dashboard/src/admin/TeamDetail.tsx

gtsiolis · 2022-02-24T16:31:12Z

components/dashboard/src/admin/TeamDetail.tsx

+                    </ItemField>
+                    <ItemField className="flex items-center my-auto">
+                        <span className="text-gray-400 capitalize">
+                            <DropDown contextMenuWidth="w-32" activeEntry={m.role} entries={[{


question: Did we decide to bring the role change action back?

Yes, here as a nice to have for support issues[1]

components/dashboard/src/admin/TeamsSearch.tsx

gtsiolis · 2022-02-25T08:51:48Z

Running build again as the last one failed[1].

/werft run

👍 started the job as gitpod-build-laushinka-team-admin-8060.24

gtsiolis

UX changes look great, @laushinka!

Last round! 🥊

One outstanding question is whether we'd like to include the linking back to the team from the project detail page in this PR or open a follow up issue for this. Your call. 🏓

Project in personal account	Project in team

laushinka · 2022-02-25T11:04:27Z

One outstanding question is whether we'd like to include the linking back to the team from the project detail page in this PR or open a follow up issue for this. Your call. 🏓

@gtsiolis Thank you for remembering this! Will do it, since I'm still waiting for code reviews anyway 👏🏼
Update: Done! Btw I notice that some of your deleted projects in the preview env link to a broken team link, which I'm not sure why. Were they moved? We can tackle this in a follow-up issue 🙏🏽

(Also, not sure what the "dismissed stale review is below" 😅)

jldec

Very nice work - thank you @laushinka

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed size/L labels Feb 23, 2022

laushinka force-pushed the laushinka/team-admin-8060 branch from 409e821 to 7e01108 Compare February 23, 2022 11:57

gtsiolis requested a review from a team February 23, 2022 12:12

github-actions bot added the team: product-design label Feb 23, 2022

svenefftinge removed the team: product-design label Feb 23, 2022

gtsiolis suggested changes Feb 23, 2022

View reviewed changes

roboquat added size/XL and removed size/L labels Feb 23, 2022

laushinka force-pushed the laushinka/team-admin-8060 branch 2 times, most recently from add18ba to 348b35d Compare February 23, 2022 20:49

roboquat added release-note and removed do-not-merge/release-note-label-needed labels Feb 23, 2022

laushinka force-pushed the laushinka/team-admin-8060 branch from b9d445a to 6494c5c Compare February 23, 2022 21:09

laushinka marked this pull request as ready for review February 23, 2022 21:09

laushinka requested a review from a team February 23, 2022 21:09

roboquat removed the do-not-merge/work-in-progress label Feb 23, 2022

github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 23, 2022

laushinka requested review from gtsiolis and jldec February 23, 2022 21:23

gtsiolis suggested changes Feb 24, 2022

View reviewed changes

laushinka force-pushed the laushinka/team-admin-8060 branch from 6494c5c to 5c3e131 Compare February 24, 2022 11:52

gtsiolis suggested changes Feb 24, 2022

View reviewed changes

Manage teams as admin

0cbb931

laushinka force-pushed the laushinka/team-admin-8060 branch from 67c888c to 0cbb931 Compare February 24, 2022 17:06

laushinka requested a review from gtsiolis February 25, 2022 07:30

gtsiolis previously approved these changes Feb 25, 2022

View reviewed changes

link to team from project detail

42946c5

laushinka dismissed gtsiolis’s stale review via 42946c5 February 25, 2022 11:13

gtsiolis approved these changes Feb 25, 2022

View reviewed changes

jldec approved these changes Feb 25, 2022

View reviewed changes

roboquat merged commit 84128c3 into main Feb 25, 2022

roboquat deleted the laushinka/team-admin-8060 branch February 25, 2022 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Laushinka/team admin 8060 #8402

Laushinka/team admin 8060 #8402

laushinka commented Feb 23, 2022 •

edited

Loading

laushinka commented Feb 23, 2022

codecov bot commented Feb 23, 2022 •

edited

Loading

laushinka commented Feb 23, 2022

gtsiolis commented Feb 23, 2022 •

edited

Loading

gtsiolis left a comment

laushinka commented Feb 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Feb 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Feb 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment

laushinka commented Feb 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment

gtsiolis Feb 24, 2022

laushinka Feb 24, 2022

gtsiolis commented Feb 25, 2022 •

edited

Loading

gtsiolis left a comment •

edited

Loading

laushinka commented Feb 25, 2022 •

edited

Loading

jldec left a comment

Laushinka/team admin 8060 #8402

Laushinka/team admin 8060 #8402

Conversation

laushinka commented Feb 23, 2022 • edited Loading

Description

Related Issue(s)

How to test

Release Notes

Documentation

laushinka commented Feb 23, 2022

codecov bot commented Feb 23, 2022 • edited Loading

Codecov Report

laushinka commented Feb 23, 2022

gtsiolis commented Feb 23, 2022 • edited Loading

gtsiolis left a comment

Choose a reason for hiding this comment

laushinka commented Feb 23, 2022 • edited by werft-gitpod-dev-com bot Loading

laushinka commented Feb 23, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis commented Feb 24, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment

Choose a reason for hiding this comment

laushinka commented Feb 24, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment

Choose a reason for hiding this comment

gtsiolis Feb 24, 2022

Choose a reason for hiding this comment

laushinka Feb 24, 2022

Choose a reason for hiding this comment

gtsiolis commented Feb 25, 2022 • edited Loading

gtsiolis left a comment • edited Loading

Choose a reason for hiding this comment

laushinka commented Feb 25, 2022 • edited Loading

jldec left a comment

Choose a reason for hiding this comment

laushinka commented Feb 23, 2022 •

edited

Loading

codecov bot commented Feb 23, 2022 •

edited

Loading

gtsiolis commented Feb 23, 2022 •

edited

Loading

laushinka commented Feb 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Feb 23, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Feb 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Feb 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Feb 25, 2022 •

edited

Loading

gtsiolis left a comment •

edited

Loading

laushinka commented Feb 25, 2022 •

edited

Loading