installer: always override -c config on default values
#8401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
Pothulapati
force-pushed
the
tar/installer-default
branch
from
e3cb65a to
386bd24
Compare
Codecov Report
@@ Coverage Diff @@
## main #8401 +/- ##
=========================================
- Coverage 12.31% 7.59% -4.73%
=========================================
Files 20 31 +11
Lines 1161 2172 +1011
=========================================
+ Hits 143 165 +22
- Misses 1014 2004 +990
+ Partials 4 3 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I think the As this is an update to the config, can you also run |
Pothulapati
force-pushed
the
tar/installer-default
branch
from
386bd24 to
f6261b3
Compare
Fixes #8267 Currently, Users run `init` command first, update it and pass full config to `render` to generate Kubernetes manifests. The passage of `-c` is a requirement here, and users can't skip it. This PR makes the passage of `config` to `render` optional, and flexible. This means - Users can skip `-c` entirely, in which case we use the default values on the default config version for that installer binary - Users can selectively override fields and *thus no need to pass full config* all the time. This means `-c` flag acts as a flag through which they can override the default fields. For the second case, When a user explicitely sets the `apiVersion` field in the passed config, we use the default values for that version. If no `apiVersion` is passed, we override the passed config onto the default values on the default config version for that installer binary. After this change, For users This means that they only store and use the config that has their changes only (on the default config), and not the entire config. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/installer-default
branch
from
f6261b3 to
a3232f0
Compare
corneliusludmann
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Users run
initcommand first, update it andpass full config to
renderto generate Kubernetes manifests. Thepassage of
-cis a requirement here, and users can't skip it.This PR makes the passage of
configtorenderoptional, andflexible. This means
-centirely, in which case we use the defaultvalues on the default config version for that installer binary
config all the time. This means
-cflag acts as a flag throughwhich they can override the default fields.
For the second case, When a user explicitely sets the
apiVersionfield in the passed config, we use the default values for that
version. If no
apiVersionis passed, we override the passed configonto the default values on the default config version for that
installer binary.
After this change, For users This means that they only store and use
the config that has their changes only (on the default config), and
not the entire config.
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #8267
How to test
Build the binary, with a speciifc version
VERSION="main.2514" make buildRun
renderno-cpassedRun
renderwith onlydomainsetRelease Notes
Documentation