Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Ensure ws-proxy is scheduled in different nodes #8389

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 22, 2022

Description

By default, the installer deploys one ws-proxy replica. If we need to scale up, ensure we schedule the pod in a different host.

How to test

  • Install a cluster and scale ws-proxy to more than one replica

Release Notes

[installer] Ensure multiple ws-proxy replicas are scheduled in different nodes

@aledbf aledbf requested a review from a team February 22, 2022 14:49
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #8389 (356c3cb) into main (d9b9f30) will decrease coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #8389      +/-   ##
========================================
- Coverage   8.41%   7.59%   -0.83%     
========================================
  Files         33      31       -2     
  Lines       2340    2172     -168     
========================================
- Hits         197     165      -32     
+ Misses      2138    2004     -134     
+ Partials       5       3       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app 4.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b9f30...356c3cb. Read the comment docs.

@roboquat roboquat merged commit 0943c1d into main Feb 22, 2022
@roboquat roboquat deleted the aledbf/spread branch February 22, 2022 18:13
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants