Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Use fuse as default ShiftFS method #8346

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

corneliusludmann
Copy link
Contributor

Description

Set fuse as the default ShiftFS method again since it has been fixed in #8181 and is more robust than shiftfs.

This reverts 5f9f701.

Internal discussion:

Release Notes

[installer] Use fuse as default ShiftFS method.

Meta

/werft no-preview

@corneliusludmann corneliusludmann requested a review from a team February 21, 2022 13:04
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #8346 (4036887) into main (e111296) will decrease coverage by 4.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #8346      +/-   ##
=========================================
- Coverage   12.31%   7.60%   -4.72%     
=========================================
  Files          20      31      +11     
  Lines        1161    2171    +1010     
=========================================
+ Hits          143     165      +22     
- Misses       1014    2003     +989     
+ Partials        4       3       -1     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-installer-raw-app 4.58% <ø> (?)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/installer/pkg/common/storage.go 0.00% <0.00%> (ø)
...s/installer/pkg/components/ws-manager/configmap.go 24.37% <0.00%> (ø)
...installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
.../installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go 0.00% <0.00%> (ø)
...s/installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
components/installer/pkg/common/ca.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e111296...4036887. Read the comment docs.

@mrsimonemms
Copy link
Contributor

/approve
/lgtm

@roboquat roboquat merged commit 6d62346 into main Feb 21, 2022
@roboquat roboquat deleted the clu/use-default-shiftfs branch February 21, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants