[installer] Add MINIO_SKIP_CLIENT=yes to minio #8270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This skips MinIO client configuration in the minio container. The client configuration leads to a crash loop on air-gap installations and since we don't use the minio client in Gitpod we simply skip the client configuration. /werft no-preview
github-actions
bot
added
the
team: delivery
mrsimonemms
approved these changes
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #8270 +/- ##
==========================================
- Coverage 31.21% 8.15% -23.07%
==========================================
Files 39 31 -8
Lines 5908 2184 -3724
==========================================
- Hits 1844 178 -1666
+ Misses 3924 2003 -1921
+ Partials 140 3 -137
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This skips MinIO client configuration in the minio container. The client configuration leads to a crash loop on air-gap installations and since we don't use the minio client in Gitpod we simply skip the client configuration.
Related Issue(s)
Fixes #8269
How to test
The only way to test this is to install a Gitpod installation with built-in MinIO and verify that everything still works. I did this and everything works.
Release Notes
Meta
/werft no-preview