Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load test proc mount in a workspace #8234

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Load test proc mount in a workspace #8234

merged 5 commits into from
Feb 16, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Feb 16, 2022

Description

  • Add stress test for mount proc
  • Fix workspace tests not running

Related Issue(s)

Fixes #8098

How to test

Release Notes

Add stress test for mount proc

Documentation

No

utam0k
utam0k commented Feb 16, 2022
View reviewed changes
test/leeway-build.sh
@@ -19,4 +19,5 @@ for COMPONENT in tests/components/*; do
go test -trimpath -ldflags="-buildid= -w -s" -c -o bin/"$OUTPUT".test ./"$COMPONENT"
done

go test -trimpath -ldflags="-buildid= -w -s" -o bin/workspace -c ./tests/workspace
echo building test tests/workspace
go test -trimpath -ldflags="-buildid= -w -s" -o bin/workspace.test -c ./tests/workspace
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the workspace test had not been run before, but I didn't know why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref:

gitpod/test/entrypoint.sh

Line 14 in 30da763

for i in $(find /tests/ -name "*.test" | sort); do

utam0k
utam0k commented Feb 16, 2022
View reviewed changes
test/tests/workspace/mount_proc_test.go
Comment on lines +23 to +24
numberOfMount = 500
parallel = 5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no material to determine if it was a reasonable number. Do you have a good idea?
If it takes too long and becomes a problem, I'd consider adding an annotation for stress testing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have used 1000 mounts before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to go with 1000 at first, but I'm having trouble finding any evidence that 1000 and 500 are different. The larger the number, the longer it takes to test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then lets go with 500 for now. If we see this problem again and the test does not show it, we can increase the number of iterations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Furisto Thanks for your review!

@utam0k utam0k requested a review from a team February 16, 2022 02:00
@utam0k utam0k added the team: workspace Issue belongs to the Workspace team label Feb 16, 2022
@utam0k
Copy link
Contributor Author

utam0k commented Feb 16, 2022

wertf passed this integration test.
https://werft.gitpod-dev.com/job/gitpod-run-integration-tests-to-proc-test.12

@codecov
Copy link

codecov bot commented Feb 16, 2022 •
edited
Loading

Codecov Report

Merging #8234 (19a5d1f) into main (f3da7ba) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8234      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3da7ba...19a5d1f. Read the comment docs.

@roboquat roboquat merged commit 42d529c into main Feb 16, 2022
@roboquat roboquat deleted the to/proc-test branch February 16, 2022 12:32
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Furisto Furisto Furisto approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[integration-test] Load test proc mount in a workspace
3 participants
@utam0k @Furisto @roboquat