Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] disable perMessageDeflate on websockets #8227

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Feb 15, 2022

... which should improve memory usage.

[server] Disable `perMessageDeflate` on websockets

@AlexTugarev AlexTugarev requested a review from a team February 15, 2022 15:23
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 15, 2022
@geropl
Copy link
Member

geropl commented Feb 15, 2022

@AlexTugarev leaving a comment would be awesome.

... which should improve memory usage.
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexTugarev
Copy link
Member Author

@geropl, good point. added a reference to the docs.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #8227 (40ea6e2) into main (08d0c6c) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8227      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d0c6c...40ea6e2. Read the comment docs.

@roboquat roboquat merged commit 236523e into main Feb 15, 2022
@roboquat roboquat deleted the at/perMessageDeflate branch February 15, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants