Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Disable tracing errors #8187

Merged
merged 4 commits into from
Feb 14, 2022
Merged

[server] Disable tracing errors #8187

merged 4 commits into from
Feb 14, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Feb 14, 2022

Description

  • server: don't use FOLLOWS_FROM references
  • replace references by manually enriching spans for websocket notifications
  • set JAEGER_DISABLED when tracing is not configured explicitly to avoid noisy error messages (for SH case, for example)

Related Issue(s)

Fixes #

How to test

  • as with-observability is not working atm:
    • kubectl logs server-79dfdf9bbd-f6fmn server -f
    • start a workspace
    • note that the server logs do not contain any tracing-related errors/warnings

Release Notes

[tracing] avoid noisy error messages

Documentation

  • /werft with-observability=true
  • /werft with-helm=true
  • /werft with-clean-slate-deployment

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #8187 (f3db54d) into main (c4b0983) will decrease coverage by 20.98%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #8187       +/-   ##
==========================================
- Coverage   29.13%   8.15%   -20.99%     
==========================================
  Files          83      31       -52     
  Lines       13182    2184    -10998     
==========================================
- Hits         3840     178     -3662     
+ Misses       9029    2003     -7026     
+ Partials      313       3      -310     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
components-ws-manager-app ?
installer-raw-app 5.62% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/common.go 4.43% <0.00%> (-0.02%) ⬇️
components/supervisor/pkg/ports/ports.go
components/supervisor/pkg/dropwriter/dropwriter.go
components/supervisor/pkg/supervisor/tasks.go
components/ws-daemon/pkg/content/tar.go
components/ws-manager/pkg/manager/status.go
components/supervisor/pkg/ports/exposed-ports.go
components/ws-manager/pkg/manager/imagespec.go
...mponents/supervisor/pkg/supervisor/notification.go
components/ws-daemon/pkg/cpulimit/dispatch.go
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b0983...f3db54d. Read the comment docs.

@geropl
Copy link
Member Author

geropl commented Feb 14, 2022

/werft run

👍 started the job as gitpod-build-gpl-tracing-disable-errors.3

@geropl
Copy link
Member Author

geropl commented Feb 14, 2022

/werft run

👍 started the job as gitpod-build-gpl-tracing-disable-errors.4

@geropl geropl marked this pull request as ready for review February 14, 2022 11:31
@geropl geropl requested review from a team February 14, 2022 11:31
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Feb 14, 2022
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@geropl
Copy link
Member Author

geropl commented Feb 14, 2022

/werft run

👍 started the job as gitpod-build-gpl-tracing-disable-errors.7

🤞

@geropl
Copy link
Member Author

geropl commented Feb 14, 2022

/werft run

👍 started the job as gitpod-build-gpl-tracing-disable-errors.8

@geropl
Copy link
Member Author

geropl commented Feb 14, 2022

with-observability does not work at the moment, so we test the tracing changes in server by starting a workspace, which shows there are no errors (without checking the actual structure in honeycomb).

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Pull Request!

Already approved by Simon, thus simply skimmed briefly and rubber-stamping on behalf of Team WebApp. 🚀

@roboquat roboquat merged commit 7c8c846 into main Feb 14, 2022
@roboquat roboquat deleted the gpl/tracing-disable-errors branch February 14, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/L team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants