-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Disable tracing errors #8187
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8187 +/- ##
==========================================
- Coverage 29.13% 8.15% -20.99%
==========================================
Files 83 31 -52
Lines 13182 2184 -10998
==========================================
- Hits 3840 178 -3662
+ Misses 9029 2003 -7026
+ Partials 313 3 -310
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/werft run 👍 started the job as gitpod-build-gpl-tracing-disable-errors.3 |
/werft run 👍 started the job as gitpod-build-gpl-tracing-disable-errors.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/werft run 👍 started the job as gitpod-build-gpl-tracing-disable-errors.7 🤞 |
/werft run 👍 started the job as gitpod-build-gpl-tracing-disable-errors.8 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Pull Request!
Already approved by Simon, thus simply skimmed briefly and rubber-stamping on behalf of Team WebApp. 🚀
Description
JAEGER_DISABLED
when tracing is not configured explicitly to avoid noisy error messages (for SH case, for example)Related Issue(s)
Fixes #
How to test
with-observability
is not working atm:kubectl logs server-79dfdf9bbd-f6fmn server -f
server
logs do not contain any tracing-related errors/warningsRelease Notes
Documentation