Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Add start request debug log #8161

Merged
merged 1 commit into from
Feb 12, 2022
Merged

[ws-manager] Add start request debug log #8161

merged 1 commit into from
Feb 12, 2022

Conversation

csweichel
Copy link
Contributor

Description

This PR adds debug request logging to ws-manager for environments where there is no distributed tracing available, e.g. in many self-hosted installations.

How to test

  1. Enable debug logging for ws-manager (gpctl debug logs ws-manager)
  2. Start a workspace
  3. Observe the logs of ws-manager and find the logged out workspace start request

Release Notes

Add workspace start request debug logging to ws-manager

@csweichel csweichel requested a review from a team February 11, 2022 16:45
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #8161 (c132f04) into main (0ef0c9f) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8161      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef0c9f...c132f04. Read the comment docs.

@roboquat roboquat merged commit 3d148ff into main Feb 12, 2022
@roboquat roboquat deleted the cw/wsman-req-log branch February 12, 2022 02:42
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants