Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Support git lfs #8119

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[ws-daemon] Support git lfs #8119

merged 1 commit into from
Feb 9, 2022

Conversation

csweichel
Copy link
Contributor

Description

This PR adds support for Git LFS during content init. Content init runs in the context of ws-dameon, hence git-lfs needs to be installed there.

Related Issue(s)

Fixes #8105

How to test

  1. Open a repo with Git LFS enabled

Release Notes

Added support for Git LFS during content init

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #8119 (b6f47d2) into main (e0f7bfe) will increase coverage by 18.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8119       +/-   ##
===========================================
+ Coverage   11.98%   30.90%   +18.92%     
===========================================
  Files          20       37       +17     
  Lines        1193     5814     +4621     
===========================================
+ Hits          143     1797     +1654     
- Misses       1046     3880     +2834     
- Partials        4      137      +133     
Flag Coverage Δ
components-gitpod-cli-app 10.82% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app 35.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/supervisor/pkg/terminal/ring-buffer.go 45.65% <0.00%> (ø)
components/supervisor/pkg/ports/exposed-ports.go 0.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go 21.52% <0.00%> (ø)
...mponents/supervisor/pkg/supervisor/notification.go 83.95% <0.00%> (ø)
components/supervisor/pkg/ports/served-ports.go 80.76% <0.00%> (ø)
components/supervisor/pkg/ports/ports-config.go 80.00% <0.00%> (ø)
components/supervisor/pkg/terminal/terminal.go 63.60% <0.00%> (ø)
components/supervisor/pkg/supervisor/ssh.go 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f7bfe...b6f47d2. Read the comment docs.

@csweichel csweichel marked this pull request as ready for review February 9, 2022 12:58
@csweichel csweichel requested a review from a team February 9, 2022 12:58
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 9, 2022
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit ee3bd40 into main Feb 9, 2022
@roboquat roboquat deleted the cw/fix-8105 branch February 9, 2022 14:40
@kylos101
Copy link
Contributor

kylos101 commented Feb 9, 2022

Also created this issue, so that we add a related integration test.

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Git LFS during content init
3 participants