-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Ship env vars as one-time secret" #8082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
Revert is because of env var breakage in prod: #7923 (comment)
Codecov Report
@@ Coverage Diff @@
## main #8082 +/- ##
=========================================
- Coverage 12.01% 8.04% -3.97%
=========================================
Files 20 31 +11
Lines 1190 2212 +1022
=========================================
+ Hits 143 178 +35
- Misses 1043 2031 +988
+ Partials 4 3 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Reverts #7923
Due to a bug in the Env Var injection.