telemetry: add more fields to data #8067
Conversation
| @@ -23,6 +23,11 @@ export interface InstallationAdmin { | |||
| settings: InstallationAdminSettings; | |||
| } | |||
|
|
|||
| export interface Data { | |||
| installationAdmin: InstallationAdmin | |||
| totalUsers: number | |||
There was a problem hiding this comment.
As we add more telemetry data, We could continue adding them here thereby separating it from the InstallationAdmin (which integrates into the database).
There was a problem hiding this comment.
Same goes with the new Data struct for the golang side of things in installation-telemetry workspace
Codecov Report
@@ Coverage Diff @@
## main #8067 +/- ##
==========================================
+ Coverage 10.20% 10.86% +0.65%
==========================================
Files 18 18
Lines 1009 1022 +13
==========================================
+ Hits 103 111 +8
- Misses 905 909 +4
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Still there is work on wiring these metrics into the |
Pothulapati
changed the title
totalUsers field to data
components/server/src/installation-admin/installation-admin-controller.ts
Outdated
Show resolved
Hide resolved
|
@Pothulapati Since we rebase and merge, it would be good when you can clean up your commits and squash them into one commit. ❤️ |
Pothulapati
force-pushed
the
tarun/telemetry-users
branch
from
7c89847 to
0dfee7b
Compare
Pothulapati
force-pushed
the
tarun/telemetry-users
branch
from
0dfee7b to
7c89847
Compare
Fixes #7866 This PR updates the `installation-admin-controller` to also retrieve more data to send with telemetry. These are not part of the `installationAdminDb` as we do not want to store this in the database but lazily retrieve whenever a request is sent to `/data` endpoint of the `installation-admin` express app unlike the `uuid` and settings which need to be stored and updated. The following fields are added: - `totalUsers` : specifies the total number of users in the instance - `totalWorkspaces`: specifies the total number of **regular** workspaces in the instance - `totalInstances`: specifies the total number of **regular** workspace instances in the gitpod instance Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tarun/telemetry-users
branch
from
7c89847 to
7547d11
Compare
|
@corneliusludmann Done! |
Description
This PR updates the
installation-admin-controllerto also retrievemore data to send with telemetry. These are not part of the
installationAdminDbas we do not want to store this in the databasebut lazily retrieve whenever a request is sent to
/dataendpointof the
installation-adminexpress app unlike theuuidand settingswhich need to be stored and updated.
The following fields are added:
totalUsers: specifies the total number of users in the instancetotalWorkspaces: specifies the total number of regular workspaces in the instancetotalInstances: specifies the total number of regular workspace instances in the gitpod instanceRelated Issue(s)
Fixes #7866
How to test
Deploy via werft and do a
/dataGETon the9000port ofserver.yarn telepresencein/serverkubectl port-forward svc/server 9000curl -H "Content-Type: application/json" http://localhost:9000/dataSample Output:
Release Notes
Documentation