Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2022.01 #7873

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Release 2022.01 #7873

merged 2 commits into from
Jan 28, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Jan 27, 2022 •
edited
Loading

Description

The first proper release of the Installer 🎉 🎉 🥳

This is mostly documentation and stuff to help the build. The only code change is to add in a build tag for embedVersion, to allow for the build step to incorporate the versions at build time. This is in addition to the previous two methods of bringing the versions (use of --debug-version-file flag and amending binary with objcopy) This was added because cannot run the objcopy when doing cross-platform builds.

Related Issue(s)

Fixes #7658

How to test

All testing within AWS/Azure/GCP has been done as part of this PR, conforming to the tests defined in #7789

Release Notes

[Installer]: release 2022.01

Documentation

@roboquat roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed team: IDE team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team size/M labels Jan 27, 2022
@mrsimonemms mrsimonemms added this to the release/2022.01 milestone Jan 27, 2022
@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jan 27, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-release-2022.01.5

@codecov
Copy link

codecov bot commented Jan 27, 2022 •
edited
Loading

Codecov Report

Merging #7873 (9cb3d3f) into main (76332f9) will increase coverage by 1.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #7873      +/-   ##
=========================================
+ Coverage   8.57%   10.20%   +1.63%     
=========================================
  Files         33       18      -15     
  Lines       2355     1009    -1346     
=========================================
- Hits         202      103      -99     
+ Misses      2149      905    -1244     
+ Partials       4        1       -3
Flag Coverage Δ
components-gitpod-cli-app 10.20% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
installer/pkg/common/common.go
installer/pkg/common/storage.go
...components/ws-manager/unpriviledged-rolebinding.go
installer/pkg/components/ws-manager/rolebinding.go
installer/pkg/components/ws-manager/role.go
installer/pkg/common/objects.go
...staller/pkg/components/ws-manager/networkpolicy.go
installer/pkg/components/ws-manager/configmap.go
installer/pkg/common/ca.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76332f9...9cb3d3f. Read the comment docs.

@roboquat roboquat added size/L and removed size/M labels Jan 27, 2022
@mrsimonemms mrsimonemms force-pushed the release/2022.01 branch 2 times, most recently from b8d42d4 to d3ff583 Compare January 27, 2022 17:53
@mrsimonemms mrsimonemms requested a review from a team January 27, 2022 18:25
@mrsimonemms mrsimonemms self-assigned this Jan 27, 2022
@mrsimonemms mrsimonemms marked this pull request as ready for review January 28, 2022 08:36
Simon Emms added 2 commits January 28, 2022 10:19
[installer]: prepare releasable binary
7dd23a3 
Makefile is used as a convenience for ensuring correct builds for
all supported platforms. Introduced option to embed the versions.yaml
as the objcopy method doesn't work in cross-platform builds
[installer]: change default FSShiftMethod to shiftfs
9cb3d3f
corneliusludmann
corneliusludmann approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@roboquat roboquat added the lgtm label Jan 28, 2022
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: ceb3f74558c7e00d389ea3a1d8404f454d87ed45

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann

Associated issue: #7658

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 5f9f701 into main Jan 28, 2022
@roboquat roboquat deleted the release/2022.01 branch January 28, 2022 10:34
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Jan 28, 2022
@mrsimonemms mrsimonemms restored the release/2022.01 branch January 28, 2022 15:03
@mrsimonemms mrsimonemms deleted the release/2022.01 branch January 28, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusludmann corneliusludmann corneliusludmann approved these changes

Assignees

@mrsimonemms mrsimonemms

@corneliusludmann corneliusludmann

Labels
approved deployed: workspace Workspace team change is running in production release-note size/L team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
release/2022.01
Development

Successfully merging this pull request may close these issues.

Create 2022.01 release
3 participants
@mrsimonemms @roboquat @corneliusludmann