Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Ensure incremental prebuilds always use the latest config #7805

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Jan 25, 2022

Description

Ensure Incremental Prebuilds always use the latest config (by always overwriting the parent prebuild's config with the most-recently fetched config).

From the in-line comment:

createForPrebuiltWorkspace 1:1 copies the config from the parent prebuild.
Above, we've made sure that the parent's prebuild tasks (before/init/prebuild) are still the same as now.
However, other non-prebuild config items might be outdated (e.g. any command task, VS Code extension, ...)
To fix this, we overwrite the new prebuild's config with the most-recently fetched config.

Related Issue(s)

Fixes #7475

How to test

See "Steps to reproduce" in #7475

Release Notes

[server] Ensure incremental prebuilds always use the latest config

Documentation

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #7805 (368ce85) into main (e335309) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7805      +/-   ##
==========================================
- Coverage   10.38%   10.20%   -0.18%     
==========================================
  Files          18       18              
  Lines         992     1009      +17     
==========================================
  Hits          103      103              
- Misses        888      905      +17     
  Partials        1        1              
Flag Coverage Δ
components-gitpod-cli-app 10.20% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/gitpod-cli/cmd/credential-helper.go 1.20% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5d13a...368ce85. Read the comment docs.

@jankeromnes jankeromnes requested a review from a team January 25, 2022 09:57
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e752d9f45bfd1bbedbd428e3ba47ee9d7403561

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #7475

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit b7d359d into main Jan 31, 2022
@roboquat roboquat deleted the jx/inc-prebuild-recent-config branch January 31, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental Prebuilds can sometimes execute an outdated config
3 participants