[installer]: add namespace to validate cluster command #7801
Conversation
roboquat
added
release-note
team: delivery
| Message: "no cluster issuers configured", | ||
| Type: ValidationStatusWarning, | ||
| }}, nil | ||
| return []ValidationError{ |
| Message: err.Error(), | ||
| Type: ValidationStatusError, | ||
| }}, nil | ||
| return []ValidationError{ |
Codecov Report
@@ Coverage Diff @@
## main #7801 +/- ##
===========================================
- Coverage 30.31% 10.20% -20.11%
===========================================
Files 119 18 -101
Lines 18748 1009 -17739
===========================================
- Hits 5683 103 -5580
+ Misses 12556 905 -11651
+ Partials 509 1 -508
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mrsimonemms
force-pushed
the
sje/installer-validate-cluster-nsp
branch
from
cb14b55 to
9e051bf
Compare
|
/assign @corneliusludmann |
|
LGTM label has been added. Git tree hash: 23c5eae892545910340f6881ff45123331d06280
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusludmann Associated issue: #7497 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adds a namespace flag to the validate cluster command. This updates the validation checks to receive the namespace from the flag.
A new check to ensure the existence of the namespace is added. The Installer does not create the namespace for reasons discussed here
Finally, have renamed the command file
validate-cluster.gotovalidate_cluster.goto maintain consistency in naming convention and fixed a couple of nits inchecks.goRelated Issue(s)
Fixes #7497
How to test
Release Notes
Documentation