[sshproxy] Add heartbeating #7760
Conversation
roboquat
added
release-note
team: workspace
Codecov Report
@@ Coverage Diff @@
## main #7760 +/- ##
===========================================
- Coverage 30.45% 10.28% -20.17%
===========================================
Files 115 18 -97
Lines 18732 1001 -17731
===========================================
- Hits 5705 103 -5602
+ Misses 12538 897 -11641
+ Partials 489 1 -488
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi @csweichel I'm currently refactoring the SSH gateway, and I've made some fixes for the issues mentioned above #7772, to avoid conflicts I set the base branch to this PR
|
Note for reviewers: re-introducing the ws-proxy <> ws-manager connection is not ideal. Down the road we could introduce a CRD/annotation-based mechanism. |
Did you mean we update the lastActiveTime on pod annotation instead of db? |
Something like that - we don't have that annotation yet because of the load this would impose on the Kubernetes control plane. If we were to introduce something like that, we would drastically reduce the update frequency, close to the theoretical maximum of 1/2 * timeout. |
|
/approve |
|
LGTM label has been added. Git tree hash: 282b72230d97a63deb90e91f901f91c50b950446
|
| }, nil | ||
| }, | ||
| PublicKeyCallback: func(conn ssh.ConnMetadata, key ssh.PublicKey) (*ssh.Permissions, error) { | ||
| args := strings.Split(conn.User(), "#") |
There was a problem hiding this comment.
change it because it broken for scp, scp use : to split host and path
There was a problem hiding this comment.
Given that we haven't officially released it to the public yet, I don't think such a change would cause much trouble
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, iQQBot Associated issue: #4779 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
roboquat
added
deployed: workspace
Description
Adds heartbeating to SSH PTY channels. This way, input from an SSH session counts towards a workspace's activity and prevents its timeout.
Related Issue(s)
Fixes #4779
How to test
ways to speed this up:
Release Notes