Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Fix invalid tag name for image build template #7752

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 21, 2022

Related Issue(s)

Fixes #7750

How to test

Release Notes

[installer] Fix invalid tag name for image build template

@roboquat roboquat added release-note team: delivery Issue belongs to the self-hosted team size/XS labels Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #7752 (0065e7d) into main (9a7411f) will decrease coverage by 3.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #7752      +/-   ##
=========================================
- Coverage   11.54%   7.84%   -3.70%     
=========================================
  Files          20      31      +11     
  Lines        1169    2166     +997     
=========================================
+ Hits          135     170      +35     
- Misses       1031    1994     +963     
+ Partials        3       2       -1     
Flag Coverage Δ
components-gitpod-cli-app 10.28% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
installer/pkg/common/display.go 0.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/common/storage.go 0.00% <0.00%> (ø)
installer/pkg/common/common.go 4.61% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7411f...0065e7d. Read the comment docs.

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 818609ac1736f52115017368c61c200b78151e50

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann

Associated issue: #7750

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 3c992ef into main Jan 24, 2022
@roboquat roboquat deleted the aledbf/ibt branch January 24, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[installer] imagebuild template is not rendered
3 participants