-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[content-init] Ensure .gitpod path is available #7749
Conversation
/werft run 👍 started the job as gitpod-build-cw-fix-7694.8 |
Codecov Report
@@ Coverage Diff @@
## main #7749 +/- ##
===========================================
+ Coverage 11.54% 30.02% +18.47%
===========================================
Files 20 106 +86
Lines 1169 17435 +16266
===========================================
+ Hits 135 5234 +5099
- Misses 1031 11750 +10719
- Partials 3 451 +448
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM label has been added. Git tree hash: 19fffa7b50f5ea26c32bd20de38c2f71cb6b870f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Furisto Associated issue: #7694 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
When repositories contain a
.gitpod
file this can cause the content initializer to fail because we use/workspace/.gitpod
internally. This change introduces special handling such cases where we try togit mv
ormv
the.gitpod
file to.gitpod.yaml
. If.gitpod.yaml
already exists, we delete.gitpod
.Related Issue(s)
Fixes #7694
How to test
Open https://cw-fix-7694.staging.gitpod-dev.com/#https://github.com/csweichel/gitpod-hello-ui-demo
If the build starts (might not complete due to other issues), we're good. Compare with prod where the build fails to start due to a content init error.
Release Notes