-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: add jaeger sampling options to the tracing object #7727
Conversation
/hold @corneliusludmann I will need your approval for this to be merged. I would also like @aledbf's approval as well as this change has been requested by him |
Codecov Report
@@ Coverage Diff @@
## main #7727 +/- ##
=========================================
- Coverage 11.46% 7.73% -3.74%
=========================================
Files 20 31 +11
Lines 1177 2199 +1022
=========================================
+ Hits 135 170 +35
- Misses 1039 2027 +988
+ Partials 3 2 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cross-posting a comment I just added to the issue: #7698 (comment) |
f282b1d
to
8109412
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Code looks code.
LGTM label has been added. Git tree hash: 562cbb58a1bd4425024bd7417597dc689617b238
|
8109412
to
21938f5
Compare
21938f5
to
a56f2d8
Compare
a56f2d8
to
37d5cd2
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledbf is on vacation, so approving on his behalf. LGTM.
LGTM label has been added. Git tree hash: 80e1d8e96bce3a7cb2e6d171476f33ebdaf2d674
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusludmann, JanKoehnlein, sagor999 Associated issue: #7698 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adds Jaeger sampling options to the new experimental (and unsupported) config section
The config object is now:
This adds the ability to configure the sampler options for the tracing object. This validates the types/params against the Jaeger client
There is validation added to support this:
tracing
is omitted orsamplerType
or not configured, no error happens. This retains the sameconst
and1
default values as nowtracing.samplerType
is added, it ensures that thesamplerType
meets one of the options defined by Jaeger. It also requires thetracing.samplerParam
, as this value is coupled to thesamplerType
Related Issue(s)
Fixes #7698
How to test
Run
validate config
whilst changing the params to check the validation. Runrender
to generate a new Installer YAMLRelease Notes
Documentation