Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump libseccomp" #7714

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Revert "Bump libseccomp" #7714

merged 2 commits into from
Jan 20, 2022

Conversation

csweichel
Copy link
Contributor

Reverts #7657

this broke core-dev and staging.

@roboquat
Copy link
Contributor

@csweichel: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #7714 (1cdd4b2) into main (a150551) will increase coverage by 3.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #7714      +/-   ##
=========================================
+ Coverage   9.93%   13.84%   +3.91%     
=========================================
  Files         24       48      +24     
  Lines       1883     5026    +3143     
=========================================
+ Hits         187      696     +509     
- Misses      1690     4264    +2574     
- Partials       6       66      +60     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-workspacekit-app 7.19% <ø> (ø)
components-ws-daemon-app 22.08% <ø> (?)
components-ws-daemon-lib 22.08% <ø> (?)
installer-raw-app 5.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
components/ws-daemon/pkg/content/hooks.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
installer/pkg/common/common.go 4.61% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a150551...1cdd4b2. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jan 20, 2022

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 58e1b8371c8431a4ba7c0b97f221199b1f26b174

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #7657

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production size/XXL team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants